fundamental changes for building via SPM with AA+ 2.44

onekiloparsec / SwiftAA

The most comprehensive collection of accurate astronomical algorithms in (C++, Objective-C and) Swift.

http://www.onekiloparsec.dev/

MIT License

171 stars 31 forks source link

fundamental changes for building via SPM with AA+ 2.44 #113

Closed vincentneo closed 1 year ago

vincentneo commented 2 years ago

This should fix #112

There are 2 ways to solve this problem.

AA+ added VSOP2013 algorithm file (AAVSOP2013.h and AAVSOP2013.cpp), which makes use of C++ 17 filesystem APIs, which are only available on macOS 10.15 / iOS 13 and above. (Read about it here: https://stackoverflow.com/q/58667853)

One way is to raise deployment, but since SwiftAA doesn't (yet) use VSOP2013 file, another way is to exclude necessary files, which is the method used for this pull request.

onekiloparsec commented 1 year ago

This looks great, thanks again @vincentneo for your contribution. My main concern, once merged, is my difficulties to make the releases. But I will do!

vincentneo commented 1 year ago

yeah I'll try to see if i can help regarding the pod spec issue too.

onekiloparsec commented 1 year ago

Anyway, no need to wait for merging, this looks perfectly OK to me.