search

onekiloparsec / SwiftAA

The most comprehensive collection of accurate astronomical algorithms in (C++, Objective-C and) Swift.
http://www.onekiloparsec.dev/
MIT License
172 stars 31 forks source link

Fix build failing by removing copy framework to SwiftAA playground build phase #18

Closed ruslankmlv closed 7 years ago

ruslankmlv commented 7 years ago

Building the project fails since Resources folder inside of SwiftAA.playground does not exist (Xcode creates it once you put something inside that folder, but it fails from a build phase). So I had to remove that build phase for now. If you have a better idea how to fix this error, please let me know.

onekiloparsec commented 7 years ago

Thanks a lot for your work. Indeed, that Playground needed some updates. But I realise that hard-coded filesystem paths still remain (simply yours instead of mine) in the file SwiftAA/SwiftAA.playground/SolarSystemView.remap. I would be glad to merge the request, once we've found a solution for that, and a proper workflow for the Playground.

onekiloparsec commented 7 years ago

After checking, I decided I will merge your PR to let things move forward, but I'll reintroduce the copy of the framework into the Playground. Otherwise, we don't have a distributable Playground. I'll try to add *.remap files in .gitignore as well.