search

onekiloparsec / SwiftAA

The most comprehensive collection of accurate astronomical algorithms in (C++, Objective-C and) Swift.
http://www.onekiloparsec.dev/
MIT License
172 stars 31 forks source link

Fix rise transit set for timezones #57

Closed andris-zalitis closed 7 years ago

andris-zalitis commented 7 years ago

Close #56

Waiting on #55

codecov[bot] commented 7 years ago

Codecov Report

Merging #57 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   32.43%   32.43%   +<.01%     
==========================================
  Files         226      226              
  Lines       12779    12784       +5     
==========================================
+ Hits         4145     4147       +2     
- Misses       8634     8637       +3
Impacted Files Coverage Δ
SwiftAA/JulianDay.swift 65.06% <100%> (+1.76%) :white_check_mark:
SwiftAA/RiseTransitSet.swift 100% <100%> (ø) :white_check_mark:
SwiftAA/NumericType.swift 73.33% <0%> (-4%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f31dcff...7614b1e. Read the comment docs.

onekiloparsec commented 7 years ago

With the commits solving the problem of rise & transit & set times (see discussion in #56), it becomes clear we don't need the timezone to compute them. Hence this this PR isn't relevant anymore.