onekiloparsec / SwiftAA

The most comprehensive collection of accurate astronomical algorithms in (C++, Objective-C and) Swift.
http://www.onekiloparsec.dev/
MIT License
171 stars 31 forks source link

Compile Error with XCode 11, Swift 4.x #89

Closed gregav closed 4 years ago

gregav commented 4 years ago

Hi,

I am getting several compile errors: Type 'Day' does not conform to protocol 'AdditiveArithmetic'... Type 'Degree' does not conform to protocol 'AdditiveArithmetic'....

Thank you

onekiloparsec commented 4 years ago

Hi. Are you on the swift4 branch ?

I checked out this branch, and run the tests suites with success. I'm using Xcode 11.3.1.

gregav commented 4 years ago

Hi, I am using pods, should I add extra in version or something. I have tried also ob empty project. The same.

On 28 Mar 2020, at 17:10, Cédric Foellmi notifications@github.com wrote:

 Hi. Are you on the swift4 branch ?

I checked out this branch, and run the tests suites with success. I'm using Xcode 11.3.1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

onekiloparsec commented 4 years ago

Could you post here your Podfile for me to test?

gregav commented 4 years ago

Here I have packed whole test project

https://www.dropbox.com/s/pn150ed5rlcv4mf/astro.zip?dl=0 https://www.dropbox.com/s/pn150ed5rlcv4mf/astro.zip?dl=0

I am using latest XCode Version 11.4 (11E146)

thank you for help, best regards, Grega

On 28 Mar 2020, at 19:06, Cédric Foellmi notifications@github.com wrote:

Could you post here your Podfile for me to test?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/onekiloparsec/SwiftAA/issues/89#issuecomment-605497598, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABAMHPBEMQTID7H4YH4XBLRJY4BNANCNFSM4LULZJUQ.

onekiloparsec commented 4 years ago

Just opened your project and compiled. It fails because of an error which is the issue #90 Will make an updated release today.

onekiloparsec commented 4 years ago

Fixed. Upgrade to v2.2.3. You may consider support at some point, thanks! https://patreon.com/onekiloparsec