search

onelogin / drupal-saml

MIT License
14 stars 17 forks source link

adding arbitrary role handling to user provisioning #17

Closed danny2p closed 9 years ago

danny2p commented 9 years ago

In the case of arbitrary role mapping (admin wants to map OneLogin "Department" -> Drupal role), check if the corresponding role exists in drupal and assign it to the roles array in foreach loop.

Additionally, don't destroy roles array when adding "authenticated user" in switch statement.

danny2p commented 9 years ago

Fixed the tabs -> space issue.

In drupal, users almost always have multiple roles. "Authenticated user" belongs by default to anyone with login credentials, but most organizations that would leverage SSO will want to map departmental, editorial, etc roles to their users.

Drupal allows administrators to create any number of roles, each role mapped to very granular permissions and access, and you can associate any number of roles to a given user.

pitbulk commented 9 years ago

Ok thanks, right now I don't have time to test and improve it based on the info that you gaved to me, but I will merge it soon.

Thanks for contribute. Related to #16

danny2p commented 9 years ago

No problem. Really appreciate your responsiveness. I have that code running on our dev site, and will let you know if I encounter any issues w/ those changes when we roll it to production.

On 2/10/2015 4:39 PM, Sixto Martin wrote:

Ok thanks, for the PR, right now I don't have time to test and improve it based on the info that you gaved to me, but I will merge it soon.

Thanks for contribute.

— Reply to this email directly or view it on GitHub https://github.com/onelogin/drupal-saml/pull/17#issuecomment-73808335.

pitbulk commented 9 years ago

Perfect.

pitbulk commented 9 years ago

@rehabllc Do you have this PR in production? I plan to test it and merge it this week.

danny2p commented 9 years ago

Sorry for the delay -- we are using this, though since we've added some customizations unique to our needs and some specific many-to-one role mappings, but the fundamental code is still there.

On 4/16/2015 2:31 PM, Sixto Martin wrote:

@rehabllc https://github.com/rehabllc Do you have this PR in production? I plan to test it and merge it this week.

— Reply to this email directly or view it on GitHub https://github.com/onelogin/drupal-saml/pull/17#issuecomment-93833078.