search

onelogin / drupal-saml

MIT License
14 stars 17 forks source link

Drupal Formatting #25

Closed willhallonline closed 5 years ago

willhallonline commented 8 years ago

Hi there,

I have been looking into the module and as it is at the moment it probably isn't in quite the correct state to be accepted onto drupal.org

Basically, I am wondering how I would split apart some bits so that it could be accepted potentially in the future. How much support do you have for the php library? I know at the moment, the simplesamlphp library is the most popular way of using saml with Drupal. Which uses this module https://drupal.org/project/simplesamlphp_auth

I will start a fork and make a pull request for some parts and report back more later.

pitbulk commented 8 years ago

Hi @willhallonline,

I'm the maintainer of the php-saml toolkit, you can see that is a very active project ;) Is an alternative of simpleSAMLphp, which sometimes is quite complex to set up.

Thanks for taking the time to adapt this module, my expertise is on PHP and SAML but this was my first Drupal module and can't spend time to learn it since my goal is to provide SAML support to any open source software rather than making perfect modules. That why help is always welcome to adapt my work to follow each software guidelines.

Let me know i f you have any doubt.

pitbulk commented 8 years ago

@willhallonline, in what status is the Drupal adaptation?

pitbulk commented 8 years ago

@willhallonline do you have time to send a PR with the format changes?

willhallonline commented 7 years ago

Hey. At the moment, for me it is just looking like too much work to do. How much of the module replicates what is in the php-saml toolkit, just extends it, or is it a complete saml solution inside the module?

I do know of a few people who have worked with simplesamlphp and I don't particularly like having to drag it around as a library.