search

onelogin / moodle-saml

OneLogin SAML plugin for Moodle
MIT License
8 stars 10 forks source link

Bug with wrong authlib.php url on Darwin #1

Closed cstones closed 9 years ago

cstones commented 9 years ago

Darwin has win in it. So this code uses the wrong url for Mac OS X. (PHP_OS returns Darwin etc)

    if (stristr(strtolower(PHP_OS), "win") === false) {
        require_once($CFG->libdir.'/authlib.php');
    } else {
        require_once($CFG->libdir.'\authlib.php');
    }

A quick replacement addresses the issue..

$phpos = strtolower(PHP_OS);
if (stristr($phpos, "win") === false or "darwin" === $phpos)
{ require_once($CFG->libdir.'/authlib.php'); }

else
{ require_once($CFG->libdir.'\authlib.php'); }
pitbulk commented 9 years ago

Thanks for report that. I will use this code that appears in different places on moodle:

if (stristr(PHP_OS, 'win') && !stristr(PHP_OS, 'darwin')) {
    require_once($CFG->libdir.'/authlib.php');
} else {
    require_once($CFG->libdir.'\authlib.php');
}