search

onelogin / moodle-saml

OneLogin SAML plugin for Moodle
MIT License
8 stars 10 forks source link

Moodle code guidelines changes #2

Open brendanheywood opened 8 years ago

brendanheywood commented 8 years ago

hi @pitbulk,

Would you be open to some pull requests which change the directory structure and code to that it conforms to the moodle guidelines? In particular moving the code out of /auth/onelogin_saml and into the route, and then a whole bunch of minor formatting to the glue code along these lines:

https://docs.moodle.org/dev/Coding_style

pitbulk commented 8 years ago

Yes, I'm always open to improvements.

brendanheywood commented 8 years ago

Is there any support for back channel logout?

pitbulk commented 8 years ago

No :( El 27 oct. 2015 13:31, "Brendan Heywood" notifications@github.com escribió:

Is there any support for back channel logout?

— Reply to this email directly or view it on GitHub https://github.com/pitbulk/moodle-onelogin/issues/2#issuecomment-151476575 .

brendanheywood commented 8 years ago

Doh, that's a show stopper for us and pretty well any enterprise adoption :(