onelogin / onelogin-aws-cli-assume-role

MIT License
29 stars 38 forks source link

Support durationSeconds on AssumeRoleWithSAMLReques #11

Closed pitbulk closed 5 years ago

pitbulk commented 6 years ago

Currently the toolkit executes AssumeRoleWithSAMLRequest without set the durationSeconds

On the current aws-java-sdk-sts version used (1.11.191 the value initialization was omitted because by default is set to 3600 (1h) that was the max, but in a newer version that changed and the setting can have a value from 1 hour to 12 hours.

See role's maximum session duration setting (AWS API)

rfein-hearst commented 6 years ago

👍 please

tzahiba commented 6 years ago

Please !

marky-mark commented 5 years ago

forking and ill send in a PR

pitbulk commented 5 years ago

I already implemented this and other features, but still testing the code.

marky-mark commented 5 years ago

ok ill wait, thanks

jutley commented 5 years ago

Any idea when we will get this feature? We're revamping our Kubernetes authentication strategy, and being able to support 12 hour tokens would be a huge help.