search

onelogin / onelogin-go-sdk

golang sdk for onelogin apis
MIT License
10 stars 24 forks source link

SAML assertion #31

Closed braun1928 closed 1 year ago

braun1928 commented 3 years ago

Hi, I forked the project to try and add SAML assertion support, as I'm trying to migrate a Python application that requires this. It basically works, as long as I don't have an error during the authentication, as it enters a loop in olhttp.executeHTTP to try and fetch a new Bearer token -- it doesn't distinguish between a SAML authn error and a OAuth one.

Check PR #30 as an initial work. The diff in client.go is due to VS Code import reordering.

Jmfwolf commented 1 year ago

@braun1928 would you be willing to try the latest version of the Go SDK and see if it resolves this issue?

braun1928 commented 1 year ago

Hey @Jmfwolf I unfortunately cannot The company I work in has moved from OL to Okta, so this is not an issue for me anymore. We can close the issue if this is not impacting others, too.