search

onelogin / onelogin-go-sdk

golang sdk for onelogin apis
MIT License
10 stars 24 forks source link

DEVEX-834: Add some constants from our API #47

Closed bzvestey closed 2 years ago

bzvestey commented 2 years ago

Closes #42

Added some constants for users, apps, and smart hooks.

eriktalvi commented 2 years ago

So it will work, but doesn't fit with standard GoLang conventions I've seen. Also with the convention that the rest of the code is following. If this is just internal and you want to change the convention ... Go for it (sorry). It's your code now.

But if its external, or you want to follow the convention. I'd go with the MixedCaps/mixedCaps that the rest of the code seems to be using. I'd also specify the type as that's another thing the rest of the code seems to be doing.

example 1 example 2

Otherwise it looks good to Go (sorry, last one) to me.

bzvestey commented 2 years ago

Good thought, I totally didn't think to look for other constants in the code... Made some updated @eriktalvi, let me know what you think.

eriktalvi commented 2 years ago

Looks great to me now. Too bad I cant give you the approval, but you could ping @czifro