onelogin / onelogin-go-sdk

golang sdk for onelogin apis
MIT License
10 stars 24 forks source link

AddRoleUsers (and other functionalities) doesn't seem to match the API documentation #84

Closed thisiseyal closed 1 week ago

thisiseyal commented 2 months ago

Just as an example, when looking at v2 API documentation vs. the code implementation -> AddRoleUsers doesn't accept any users as input. We can also see it in AddRoleAdmins, didn't go through all modules but I imagine it might exist in other methods too.

According to documentation, it is a POST request, and there should be an array of user_ids in data.

The postman collection of their latest version (https://www.postman.com/onelogin/onelogin-s-public-workspace/request/9dtq3tg/add-role-users) could be a good reference as well, to compare the current implementation methods and parameters with theirs.

Thanks~

Subterrane commented 1 week ago

Fixed https://github.com/onelogin/onelogin-go-sdk/pull/85