search

onelogin / onelogin-python-aws-assume-role

MIT License
58 stars 52 forks source link

Release 1.4.0 is broken with Docker: missing parentheses in call to `print` #14

Closed israel-tk closed 6 years ago

israel-tk commented 6 years ago

A recent commit introduced some lines with print "something" like https://github.com/onelogin/onelogin-python-aws-assume-role/blob/master/src/onelogin/aws-assume-role/aws-assume-role.py#L215 which are not allowed in Python 3. Simply change it to print("something").

israel-tk commented 6 years ago

BTW I suggest some CI to check that the code is compatible with Python 2 and 3 on every build. :)

pitbulk commented 6 years ago

Thanks for the PR, you are right.

israel-tk commented 6 years ago

Can we push a release 1.4.1?

pitbulk commented 6 years ago

Done

pitbulk commented 6 years ago

@israel-tk you are right now the most active dev using the script, do you have any feedback to share?

israel-tk commented 6 years ago

@pitbulk not right now, but will contact you whenever I have some! :)