search

onelogin / onelogin-python-sdk

37 stars 36 forks source link

Update python-dateutil #92

Open CTV-2023 opened 1 year ago

CTV-2023 commented 1 year ago

Hi,

I onelogin 3.1.6 to connect to Netbox tool using saml (python-saml==1.15.0)

Onelogin requires python-dateutil~=2.7.0 but we use python-dateutil 2.8.2, which is required by ghp-import 2.1.0 (requires python-dateutil >=2.8.1), used in Netbox.

Is there a way to make onelogin to accept a newer version of dateutil ?

slewis89898 commented 9 months ago

Same issue, did you find a workaround?

CTV-2023 commented 9 months ago

No unfortunately. I ignore the warning when I update Netbox as I don't use ghp-import

slewis89898 commented 9 months ago

Thanks for the quick reply. I'll try that.

slewis89898 commented 9 months ago

No unfortunately. I ignore the warning when I update Netbox as I don't use ghp-import

Hey so I figured out what was wrong - what netbox is actually looking for is not this onelogin python sdk. What it wants is python3-saml, adding that to your local_requirements.txt will fix everything (may have a slight issue when installing that package but I was able to fix that by installing one thing on the server.

CTV-2023 commented 9 months ago

No unfortunately. I ignore the warning when I update Netbox as I don't use ghp-import

Hey so I figured out what was wrong - what netbox is actually looking for is not this onelogin python sdk. What it wants is python3-saml, adding that to your local_requirements.txt will fix everything (may have a slight issue when installing that package but I was able to fix that by installing one thing on the server.

I have both in my requirements. If I remember correctly python3-saml needed it

VaibhavVadate commented 9 months ago

we are also using onelogin with fastapi pydantic v2, getting same compatible issue \venv\lib\site-packages\onelogin\models\create_app200_response.py", line 42, in CreateApp200Response one_of_schemas: List[str] = Field(CREATEAPP200RESPONSE_ONE_OF_SCHEMAS, const=True) \venv\lib\site-packages\pydantic\fields.py", line 763, in Field raise PydanticUserError('const is removed, use Literal instead', code='removed-kwargs') pydantic.errors.PydanticUserError: const is removed, use Literal instead

For further information visit https://errors.pydantic.dev/2.4/u/removed-kwargs

can we please help me on this. @onelogin-security-bot

mg-christian-axelsson commented 4 months ago

Bumping this. python-dateutil fixes deprecation warnings introduced in Python 3.12 and will hence be required in the future.