onelson commented 3 years ago

Some of the config jargon was taken directly from cargo's docs on alt registries, but could be confusing. The public facing flags and env vars have been renamed to try and make their purpose more clear.

Ex: the "API URL" is hopefully more clear when named "base url" since it acts as the prefix for other urls.

Also, while we're adding new deps, I ran a cargo update and specified patch level versions on the pre-1.0 crates (and others that play fast and lose with semver).

onelson commented 3 years ago

Need to change the README.md updated config info before this can merge.

codecov[bot] commented 3 years ago

Codecov Report

Merging #10 (b875771) into main (b44ed81) will increase coverage by 2.01%. The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   94.90%   96.92%   +2.01%     
==========================================
  Files           7        7              
  Lines         608      617       +9     
==========================================
+ Hits          577      598      +21     
+ Misses         31       19      -12

Impacted Files	Coverage Δ
src/package_index.rs	`95.91% <ø> (+1.10%)`	:arrow_up:
src/cli.rs	`87.50% <87.50%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b44ed81...b875771. Read the comment docs.

onelson / estuary

Add structop, rename some config env vars. #10

Codecov Report