search

onelson / estuary

34 stars 9 forks source link

Make blocking dupe version re-uploads configurable. #14

Closed mattdeboard closed 3 years ago

mattdeboard commented 3 years ago

This addresses onelson/estuary#12 "hackily". It's doing two things here:

  1. Gets rid of the problematic type annotation, instead of actually fixing the req/version_req problem
  2. Adds the allow_version_reupload flag to make local development simpler Instead of specifying that [this line]

(https://github.com/onelson/estuary/blob/main/src/package_index.rs#L222) is deserialized into a PackageVersion instance, I just made a smaller, very badly-named type, Partial, that is local to that block. We're only concerned with the vers attribute so Partial has a vers field.

This is probably the totally wrong approach so corrections of any kind are very welcome

mattdeboard commented 3 years ago

Closing in favor of a more focused approach in #15