search

onelson / estuary

33 stars 8 forks source link

Handle req/version_req variability ser/de for Dependency. #15

Closed mattdeboard closed 3 years ago

mattdeboard commented 3 years ago

Fixes #12

onelson commented 3 years ago

Patch looks good, but we can't provide a default for this field. Ah, I see you nixed the default. Good!

Happy to merge as-is but please standby while I add some tests to master to guard against this from an integration POV.

mattdeboard commented 3 years ago

I figured a solution to cargo publish still breaking on deserializing deps with "version_req" field instead of "req". I nuked my local upload directory (i.e. /tmp/estuary/{index,crates}) and that seemed to do the right thing. Not sure what happened there but it is sorted now! (echoes of rm -rf node_modules/)

This stubborn "breakage" was the reason I was toying with default values and all that. The cargo publish call was still failing on deserializing even with the alias, even after re-building and re-starting the server, which was really confusing (and probably PEBKAC :)).