Multirows don't work after Firefox Nightly update

onemen / TabMixPlus

New Tab mix plus for modern Firefox

Other

293 stars 16 forks source link

Multirows don't work after Firefox Nightly update #322

Closed ozzyjr closed 2 months ago

ozzyjr commented 3 months ago

After updating Firefox Nigthly this morning, I noticed that multirow stopped working. With the option activated, if the number of tabs is greater than the width of the browser window, instead of the tabs going to the bottom row, they become hidden and inaccessible. To view them again, I have to disable multirow.

Not work on Nightly 131.0a1 (2024-08-22) (64-bits) Stills work on Developer Edition 130.0b8 (64-bits) MacOs Sonoma 14.6.1

pyrates999 commented 3 months ago

do NOT download that @ozzyjr it is probably malware

onemen commented 3 months ago

There are some changes in the latest Nightly, i will work on a fix this weekend

onemen commented 3 months ago

Download this test build

Rename it to .xpi and install it.

Report back

vladko commented 3 months ago

Works fine here now (Nightly 131.0a1 (2024-08-24) (64-bit)). Just one issue: the new tab button (+) is sitting only on the top row, right. It does not want to be after the last tab.

onemen commented 3 months ago

Just one issue: the new tab button (+) is sitting only on the top row, right. It does not want to be after the last tab.

currently yes. I must be on the top row when multi-row are in overflow, scroll buttons are visible on the right side, since the last row/tab can be hidden.

i don't think it is necessary to show new tab button on both places

onemen commented 3 months ago

@vladko

report if multi-row works for you on 2nd window

Shahius commented 3 months ago

Unfortunately this test build multi-row not working on 2nd window. 1st window is ok, but 2nd still not working.

onemen commented 3 months ago

Some Firefox Nightly methods changed yesterday (Bug 1914519)

I will upload another test build later

onemen commented 3 months ago

This test build updates Tab Mix Plus code to follow the changes from:

Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events
Bug 1914332 - Consolidate arrowscrollbox horizontal & vertical property access
Bug 1914519 - Consolidate vertical mode and rtl checks in tab bar code

Download this test build

Rename it to .xpi and install it.

Report back

vladko commented 3 months ago

Tabs work in the second window for me on windows 11. Thank you!

Shahius commented 3 months ago

For me the latest test build works in several windows. Thanks.

ozzyjr commented 3 months ago

It worked. Thanks

onemen commented 2 months ago

Download and install latest development build