onepf / OpenIAB

Open In-App Billing for Google Play, SlideMe, Amazon Store, Nokia Store, Samsung Apps, Yandex.Store, Appland, Aptoide, AppMall and Fortumo.
http://onepf.org/openiab/
Apache License 2.0
474 stars 171 forks source link

Samsung Billing, update of IAP module not handled #315

Closed perpetuummedia closed 9 years ago

perpetuummedia commented 10 years ago

hi all, as far as I can see the situation when the IAP module from Samsung on device needs to be updated is not handled.. SamsungAppsBillingServive.java, initIap() sets errorCode to either BILLING_RESPONSE_RESULT_ERROR (default) or BILLING_RESPONSE_RESULT_OK.. never to actually received status code from the IAP module.

akarimova commented 10 years ago

hi @perpetuummedia, sorry for this long delay.

could you please explain what is IAP module thank you in advance

perpetuummedia commented 9 years ago

it is a software component developed by samsung that needs to be on the phone in order for an in-app purchase to be completed. They update it from time to time and when such an update is available they will send a specific response code when the lib/function is called.

RomanZhilich commented 9 years ago

Hello, thank you for you bug report. Can you please provide some documentation links? As far as I know Samsung "IAP module" is installed by Galaxy Appstore. It'd only be logical if Samsung IAB SDK would handle old version situation and redirect user to store page. If it doesn't I'm not sure what behavior to implement. Most logical probably would be to return BILLING_UNAVAILABLE after start setup.

We'll be sure carefully think it through for the upcoming version of library.

perpetuummedia commented 9 years ago

When I download the doc I checked (and confirmed) it seems as if Samsung replaced it. http://img-developer.samsung.com/contents/cmm/EN_Samsung_IAP2.0_Android_Programming_Guide_v1.0.pdf

The error code (IAP_ERROR_NEED_APP_UPGRADE -1001) is mentioned in it but no examples like previous doc.. Maybe they did indeed manage it internally....

RomanZhilich commented 9 years ago

Well looks like there's nothing to do about it at a time. Please resolve this issue if you've no further questions.