onepica / avatax

One Pica Magento extension for sales tax calculation performed by Avatax
http://www.magentocommerce.com/magento-connect/6760.html
29 stars 34 forks source link

Validate Function Issues #266

Closed KAB8609 closed 6 years ago

KAB8609 commented 7 years ago

Testing on a EE 1.14.2.1 instance.

app/code/community/OnePica/AvaTax/Model/Sales/Quote/Address.php Function validate

When a order is coming via the API, the "$this->getQuote()->getStoreId()" is not returning any results resulting in a error.

Looking at Mage_Sales_Model_Quote_Address it looks like they just do a simple fix which would look like:

if ($this->getQuote()) { if (!$this->_getConfigHelper()->fullStopOnError($this->getQuote()->getStoreId())) { return true; } }

akhoma-astound commented 7 years ago

Thanks for reporting. We will investigate your issue.

mark-netalico commented 6 years ago

Any update on this bug? I'm encountering it as well.

zamoroka commented 6 years ago

Hi @KAB8609 and @netalico,

This bug will be fixed in AvaTax 3.5.3 version. We are planning to release this version of extension until the end of this month.

Thanks for reporting

Also we must warn you that @KAB8609's solution is not correct because it fully ignores store id in this case

mark-netalico commented 6 years ago

Thanks for the update. Is there any patch you can provide in the meantime to fix this issue?

zamoroka commented 6 years ago

@netalico, unfortunately we can't provide any patches before extension will pass technical review and all tests.

mark-netalico commented 6 years ago

What about this instead?

if ($this->getQuote()) {
          if (!$this->_getConfigHelper()->fullStopOnError($this->getQuote()->getStoreId())) {
              return true;
          }
        } else {
          if (!$this->_getConfigHelper()->fullStopOnError()) {
              return true;
          }
        }
zamoroka commented 6 years ago

Hi all

Avatax 3.5.3 is released.

Release notes

You can download it from marketplace

Thanks for reporting.