Street lines missing from requests

[dave-swift]

I am not seeing the street lines show up in our AvaTax Dashboard. After looking through the request log, I see that the address is being send to AvaTax without the street info. I've included an example request in the JSON below (see the 02129 address).

After doing some quick research, the street lines are commented out in OnePica_AvaTax_Model_Avatax_Abstract::_setDestinationAddress and $street is set to an empty array.

I can't think of a good reason for doing this. I would just fix it, but it seems like it was done pretty explicitly so I thought I should check with you.

GetTaxRequest Object
(
    [CompanyCode:GetTaxRequest:private] => [REDACTED]
    [DocCode:GetTaxRequest:private] => [REDACTED]
    [DocType:GetTaxRequest:private] => SalesInvoice
    [DocDate:GetTaxRequest:private] => 2013-12-04
    [SalespersonCode:GetTaxRequest:private] => Magento
    [CustomerCode:GetTaxRequest:private] => 1
    [CustomerUsageType:GetTaxRequest:private] => 
    [Discount:GetTaxRequest:private] => 0
    [PurchaseOrderNo:GetTaxRequest:private] => 
    [ExemptionNo:GetTaxRequest:private] => 
    [OriginCode:GetTaxRequest:private] => 0
    [DestinationCode:GetTaxRequest:private] => 1
    [Addresses:GetTaxRequest:private] => Array
        (
            [0] => Address Object
                (
                    [AddressCode:Address:private] => 0
                    [Line1:Address:private] => 87 Elmwood St
                    [Line2:Address:private] => 
                    [Line3:Address:private] => 
                    [City:Address:private] => Somerville
                    [Region:Address:private] => MA
                    [PostalCode:Address:private] => 02144
                    [Country:Address:private] => US
                    [TaxRegionId:Address:private] => 0
                )

            [1] => Address Object
                (
                    [AddressCode:Address:private] => 1
                    [Line1:Address:private] => 
                    [Line2:Address:private] => 
                    [Line3:Address:private] => 
                    [City:Address:private] => Boston
                    [Region:Address:private] => MA
                    [PostalCode:Address:private] => 02129
                    [Country:Address:private] => US
                    [TaxRegionId:Address:private] => 0
                )

        )

    [Lines:GetTaxRequest:private] => Array
        (
            [0] => Line Object
                (
                    [No:Line:private] => 0
                    [OriginCode:Line:private] => 0
                    [DestinationCode:Line:private] => 1
                    [ItemCode:Line:private] => Shipping
                    [Description:Line:private] => Shipping costs
                    [TaxCode:Line:private] => FR020100
                    [Qty:Line:private] => 1
                    [Amount:Line:private] => 1.8600
                    [Discounted:Line:private] => 
                    [RevAcct:Line:private] => 
                    [Ref1:Line:private] => 
                    [Ref2:Line:private] => 
                    [ExemptionNo:Line:private] => 
                    [CustomerUsageType:Line:private] => 
                    [BatchCode:Line:private] => 
                    [TaxOverride:Line:private] => 
                    [OriginAddress:Line:private] => Address Object
                        (
                            [AddressCode:Address:private] => 0
                            [Line1:Address:private] => 87 Elmwood St
                            [Line2:Address:private] => 
                            [Line3:Address:private] => 
                            [City:Address:private] => Somerville
                            [Region:Address:private] => MA
                            [PostalCode:Address:private] => 02144
                            [Country:Address:private] => US
                            [TaxRegionId:Address:private] => 0
                        )

                    [DestinationAddress:Line:private] => Address Object
                        (
                            [AddressCode:Address:private] => 1
                            [Line1:Address:private] => 
                            [Line2:Address:private] => 
                            [Line3:Address:private] => 
                            [City:Address:private] => Boston
                            [Region:Address:private] => MA
                            [PostalCode:Address:private] => 02129
                            [Country:Address:private] => US
                            [TaxRegionId:Address:private] => 0
                        )

                    [TaxIncluded:Line:private] => 
                )

            [1] => Line Object
                (
                    [No:Line:private] => 1
                    [OriginCode:Line:private] => 0
                    [DestinationCode:Line:private] => 1
                    [ItemCode:Line:private] => 1063-S-100
                    [Description:Line:private] => Eton: Blackout Buddy
                    [TaxCode:Line:private] => P0000000
                    [Qty:Line:private] => 1.0000
                    [Amount:Line:private] => 10.46
                    [Discounted:Line:private] => 1
                    [RevAcct:Line:private] => 
                    [Ref1:Line:private] => 
                    [Ref2:Line:private] => 
                    [ExemptionNo:Line:private] => 
                    [CustomerUsageType:Line:private] => 
                    [BatchCode:Line:private] => 
                    [TaxOverride:Line:private] => 
                    [OriginAddress:Line:private] => Address Object
                        (
                            [AddressCode:Address:private] => 0
                            [Line1:Address:private] => 87 Elmwood St
                            [Line2:Address:private] => 
                            [Line3:Address:private] => 
                            [City:Address:private] => Somerville
                            [Region:Address:private] => MA
                            [PostalCode:Address:private] => 02144
                            [Country:Address:private] => US
                            [TaxRegionId:Address:private] => 0
                        )

                    [DestinationAddress:Line:private] => Address Object
                        (
                            [AddressCode:Address:private] => 1
                            [Line1:Address:private] => 
                            [Line2:Address:private] => 
                            [Line3:Address:private] => 
                            [City:Address:private] => Boston
                            [Region:Address:private] => MA
                            [PostalCode:Address:private] => 02129
                            [Country:Address:private] => US
                            [TaxRegionId:Address:private] => 0
                        )

                    [TaxIncluded:Line:private] => 
                )

        )

    [DetailLevel:GetTaxRequest:private] => Document
    [ReferenceCode:GetTaxRequest:private] => Magento Order #110191351
    [LocationCode:GetTaxRequest:private] => 
    [Commit:GetTaxRequest:private] => 
    [BatchCode:GetTaxRequest:private] => 
    [OriginAddress:GetTaxRequest:private] => Address Object
        (
            [AddressCode:Address:private] => 0
            [Line1:Address:private] => 87 Elmwood St
            [Line2:Address:private] => 
            [Line3:Address:private] => 
            [City:Address:private] => Somerville
            [Region:Address:private] => MA
            [PostalCode:Address:private] => 02144
            [Country:Address:private] => US
            [TaxRegionId:Address:private] => 0
        )

    [DestinationAddress:GetTaxRequest:private] => Address Object
        (
            [AddressCode:Address:private] => 1
            [Line1:Address:private] => 
            [Line2:Address:private] => 
            [Line3:Address:private] => 
            [City:Address:private] => Boston
            [Region:Address:private] => MA
            [PostalCode:Address:private] => 02129
            [Country:Address:private] => US
            [TaxRegionId:Address:private] => 0
        )

    [TaxOverride:GetTaxRequest:private] => 
    [CurrencyCode:GetTaxRequest:private] => USD
    [ServiceMode:GetTaxRequest:private] => Automatic
    [PaymentDate:GetTaxRequest:private] => 2013-12-04
    [ExchangeRate:GetTaxRequest:private] => 1
    [ExchangeRateEffDate:GetTaxRequest:private] => 1900-01-01
    [TaxDate:GetTaxRequest:private] => 2013-12-04
    [StatusDate:GetTaxRequest:private] => 2013-12-04
    [HashCode] => 0
    [Country] => US
)

[grikka]

IIRC, only issue in uncommenting the getStreet() line is that it might create another request call to Avalara services. You can do it, but make sure it does not create another request charge from your bucket.

[dave-swift]

Let me put it another way: how are you getting accurate tax calculations without passing the street lines?

See ZIP Codes: The Wrong Tool for the Job

[grikka]

The street line was commented out and made it into the version, it should be used.

Enable it and monitor your request usage.

[grikka]

Pushed to Master/Dev