onepiecejs / nodejs-cantas

Cantas is a real-time collaborative web application. Official repository
Other
203 stars 88 forks source link

Add global search functionality #30

Closed smilledge closed 10 years ago

smilledge commented 10 years ago

Added the global search function. It's made up of two parts;

1. Quick Search

2. Search Results Page

Notes

smilledge commented 10 years ago

Demo link is available at; http://test-cantas.rhcloud.com/

dabeng commented 10 years ago

Great user experience! the followings are my some advices:

  1. you'd better append friendly tips if you just want to display partial results -- the first 4 boards and 3 cards
  2. I think moving the 'view all results' button to the lower right corner will attract more attention
  3. highlight colour is not apparent when cursor hovers boards or cards items
  4. boards items is not easy enough to be clicked except user clicks the right section of the item.
  5. last search results should be cleared when user clears the key words
dabeng commented 10 years ago

The closed boards and archived cards should be included in the global search results. Obviously, they should be listed in the result view in the form of disabled status.

smilledge commented 10 years ago
  1. Results now show the number of displayed results are the total number of matches
  2. Done.
  3. Reverted cards back to the old style
  4. Done.
  5. Done.
  6. Done.
xiaods commented 10 years ago

test pass in local environment.

dabeng commented 10 years ago
  1. archived cards are not commented by tips like '(closed)' within closed boards
  2. we direct user to the 'closed' boards tab page and highlight the according board if he clicks the closed board in the search results window.Similarly, 'Archived Cards' widow will pop up on user clicks the archived card in the research results as well as the card is highlighted
smilledge commented 10 years ago
  1. They now have the same style as in the "My Cards" page.
  2. Done. If a use clicks on a closed board or card in a closed board they are now redirected to the "Closed Boards" page and the bard is highlighted. If the click on an archived card they are taken to the parent board and the "Archived Cards" modal is opened with the card highlighted.
dabeng commented 10 years ago

I find a bug, the following is description:

  1. search a archived card in the global search window
  2. unarchive the card
  3. re-input the same key words, I can't search the unarchived card until I refresh the page
smilledge commented 10 years ago

@dabeng Bug with archived cards is fixed.

dabeng commented 10 years ago

good job. I think this patch is ready for merge.