search

onepiecejs / nodejs-cantas

Cantas is a real-time collaborative web application. Official repository
Other
202 stars 134 forks source link

Replace deprecated Google OpenID authentication strategy with Oauth2 #39

Closed smilledge closed 10 years ago

smilledge commented 10 years ago

Replaced passport-google with passport-google-oauth.

See https://github.com/onepiecejs/nodejs-cantas/issues/38

xiaods commented 10 years ago

@smilledge thanks, need README Guide prepare. when everything is done, i can merged it.

smilledge commented 10 years ago

I added a note in README with a link to the Google Developer Console. Does it need more of an explanation?

xiaods commented 10 years ago

@smilledge I will testing it asap. when everything is works fine, i will merge it. Thanks

xiaods commented 10 years ago

through my testing on deploy to openshift, i found below issues.

  1. when i left the google settings defaut blank, it node app.js will report errors.
  2. .openshift/lib/init_settings have not mentioned, it will failed by overwrite the settings.
  3. oauth2callback url not mentioned in README. starter don't know how to handle it. maybe we need add a route in route/index.js
xiaods commented 10 years ago

route/index.js need update the google auth url to default url.

smilledge commented 10 years ago

Fixed the error from Google Auth settings not being provided.

The oauth2callback setting is optional and will default to the /auth/google/callback route. (I was only using it for debugging). I've removed the setting from the settings.json.example file as it's not required.

xiaods commented 10 years ago

@smilledge got it, i will test it asap.