search

onepremise / gReview

A Bamboo plugin integrating Gerrit which allows Bamboo to verify changes and update the Gerrit review system.
Apache License 2.0
15 stars 23 forks source link

Port 29418 still hardcoded #14

Closed sentinelpayu closed 12 years ago

sentinelpayu commented 12 years ago

There is 'connection timed out' when executin 'Gerrit Verification Processor' when custom Gerrit port is specified. I've checked with tcpdum that the plugin tries to connect using 29418 port.

Here is the log output:

30-Aug-2012 13:53:01 Finished task 'Compile' 30-Aug-2012 13:53:01 Running post build plugin 'NCover Results Collector' 30-Aug-2012 13:53:01 Running post build plugin 'Clover Results Collector' 30-Aug-2012 13:53:01 Running post build plugin 'Artifact Copier' 30-Aug-2012 13:53:01 Running post build plugin 'Gerrit Verification Processor' 30-Aug-2012 13:54:04 Failed to execute plugin 'Gerrit Verification Processor' with error: com.jcraft.jsch.JSchException: java.net.ConnectException: Connection timed out 30-Aug-2012 13:54:04 Running post build plugin 'Cleanup Build Processor' 30-Aug-2012 13:54:04 Finalising the build... 30-Aug-2012 13:54:04 Stopping timer.

onepremise commented 12 years ago

What version are you running? Are you using a remote agent?

sentinelpayu commented 12 years ago

I compiled latest 'master' branch from GitHub. Yes, I have a few remote agents connected.

Digging into the source code I think I found the problem. In GerritProcessor.java line 175 GerritService is created without the port specified.

onepremise commented 12 years ago

Ahh, nice sleuthing! You're probably right. You're welcome to provide a pull request if you already have the fix. Otherwise, I can do it later. Thanks!

sentinelpayu commented 12 years ago

I have the fix. I will do a pull request after I test it. Thank you.