Fetch connections are not closed in when using jgit

onepremise / gReview

A Bamboo plugin integrating Gerrit which allows Bamboo to verify changes and update the Gerrit review system.

Apache License 2.0

15 stars 23 forks source link

Fetch connections are not closed in when using jgit #44

Open jl431 opened 7 years ago

jl431 commented 7 years ago

FetchConnections are opened but never closed.

I think fetch connections should be closed in a finally block each time it is used within: com.houghtonassociates.bamboo.plugins.dao.jgit.JGitRepository.java

On lines 301, 359 and 385 connections are opened but never closed. It is causing an issue where it occupies a ssh connection until timeout.