search

onepremise / gReview

A Bamboo plugin integrating Gerrit which allows Bamboo to verify changes and update the Gerrit review system.
Apache License 2.0
15 stars 23 forks source link

Exception on failed build #9

Closed sentinelpayu closed 12 years ago

sentinelpayu commented 12 years ago

Look like the plugin expects that error exists at index 2 in array returned by getBuildError() which is not always the case.

[INFO] [talledLocalContainer] 2012-07-04 13:09:16,763 INFO [4-BAM::Default Agent::Agent:pool-12-thread-1] [ExecuteBuildTask] TEST-SNAPSHOT-JOB1-13: Running post build plugin 'Gerrit Verification Processor' [INFO] [talledLocalContainer] 2012-07-04 13:09:17,033 WARN [4-BAM::Default Agent::Agent:pool-12-thread-1] [ExecuteBuildTask] Failed to execute plugin with class com.houghtonassociates.bamboo.plugins.processor.GerritProcessor : TEST-SNAPSHOT-JOB1-13 [INFO] [talledLocalContainer] java.lang.IndexOutOfBoundsException: Index: 2, Size: 1 [INFO] [talledLocalContainer] at java.util.ArrayList.RangeCheck(ArrayList.java:547) [INFO] [talledLocalContainer] at java.util.ArrayList.get(ArrayList.java:322) [INFO] [talledLocalContainer] at com.houghtonassociates.bamboo.plugins.processor.GerritProcessor.buildStatusString(GerritProcessor.java:111) [INFO] [talledLocalContainer] at com.houghtonassociates.bamboo.plugins.processor.GerritProcessor.updateChangeVerification(GerritProcessor.java:179) [INFO] [talledLocalContainer] at com.houghtonassociates.bamboo.plugins.processor.GerritProcessor.call(GerritProcessor.java:137) [INFO] [talledLocalContainer] at com.atlassian.bamboo.build.pipeline.tasks.ExecuteBuildTask.performCustomBuildProcess(ExecuteBuildTask.java:161) [INFO] [talledLocalContainer] at com.atlassian.bamboo.build.pipeline.tasks.ExecuteBuildTask.call(ExecuteBuildTask.java:87) [INFO] [talledLocalContainer] at sun.reflect.GeneratedMethodAccessor282.invoke(Unknown Source) [INFO] [talledLocalContainer] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [INFO] [talledLocalContainer] at java.lang.reflect.Method.invoke(Method.java:597) [INFO] [talledLocalContainer] at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:304) [INFO] [talledLocalContainer] at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:182) [INFO] [talledLocalContainer] at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:149) [INFO] [talledLocalContainer] at org.springframework.orm.hibernate.HibernateInterceptor.invoke(HibernateInterceptor.java:117) [INFO] [talledLocalContainer] at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171) [INFO] [talledLocalContainer] at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:89) [INFO] [talledLocalContainer] at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171) [INFO] [talledLocalContainer] at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) [INFO] [talledLocalContainer] at $Proxy567.call(Unknown Source) [INFO] [talledLocalContainer] at sun.reflect.GeneratedMethodAccessor282.invoke(Unknown Source) [INFO] [talledLocalContainer] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [INFO] [talledLocalContainer] at java.lang.reflect.Method.invoke(Method.java:597) [INFO] [talledLocalContainer] at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:304) [INFO] [talledLocalContainer] at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:182) [INFO] [talledLocalContainer] at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:149) [INFO] [talledLocalContainer] at org.springframework.orm.hibernate.HibernateInterceptor.invoke(HibernateInterceptor.java:117) [INFO] [talledLocalContainer] at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171) [INFO] [talledLocalContainer] at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) [INFO] [talledLocalContainer] at $Proxy568.call(Unknown Source) [INFO] [talledLocalContainer] at com.atlassian.bamboo.v2.build.agent.DefaultBuildAgent.build(DefaultBuildAgent.java:204) [INFO] [talledLocalContainer] at com.atlassian.bamboo.v2.build.agent.BuildAgentControllerImpl.waitAndPerformBuild(BuildAgentControllerImpl.java:103) [INFO] [talledLocalContainer] at com.atlassian.bamboo.v2.build.agent.DefaultBuildAgent$1.run(DefaultBuildAgent.java:109) [INFO] [talledLocalContainer] at com.atlassian.bamboo.build.pipeline.concurrent.NamedThreadFactory$2.run(NamedThreadFactory.java:50) [INFO] [talledLocalContainer] at java.lang.Thread.run(Thread.java:662)

onepremise commented 12 years ago

Fixed. Available in 1.2.0.