Closed passsy closed 3 years ago
In actually in the process of re engineering the solution by moving the capture functionality into the base progress class.
There is now a Progress.capture constructor.
The reason for the change is that I often pass a progress into the likes of a start method which returns the same progress.
The return object had to be cast to access the captures lines.
By moving the functionality into the base progress this problem goes away.
I think? this is a better solution.
On Mon, 26 Apr 2021, 9:49 pm Pascal Welsch, @.***> wrote:
Small oversight I found while migrating
You can view, comment on, or merge this pull request online at:
https://github.com/bsutton/dcli/pull/135 Commit Summary
- Add missing export for ProgressWithCapture
File Changes
- M lib/dcli.dart https://github.com/bsutton/dcli/pull/135/files#diff-01a519e6d4a0713f6e28c3f5aad04578fc4d0fa72e8790a6fad68de4c3ba5a24 (2)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bsutton/dcli/pull/135, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG32OHJJ7AOFNYF4ZIFWZTTKVHLFANCNFSM43SXCENA .
Yes way better :)
Closed as ProgressWithCapture as been merged into Progress and is available via Progress.capture.
Small oversight I found while migrating