search

onepub-dev / dcli

An extensive library and tooling for building console/cli applications and scripts using the Dart programming language.
236 stars 26 forks source link

dcli warmup description mistake or logical error #172

Closed whoizit closed 2 years ago

whoizit commented 2 years ago

Describe the bug warmup description says 'Runs pub upgrade on the given directory.' but it's don't do pub upgrade it's do pub get. it drove me crazy and I had to go into the code to figure it out.

I think warmup means work like pub upgrade, not like pub get

bsutton commented 2 years ago

I think it should actually do a pub get.

The problem with pub upgrade it can make you app unstable by changing the dep versions all of the time.

I'm inclined to just update the warm doco to reflect that it runs pub get.

thoughts?

whoizit commented 2 years ago

you are an native English speaker, you are the author, you know best

whoizit commented 2 years ago

The problem with pub upgrade it can make you app unstable by changing the dep versions all of the time.

I agree

whoizit commented 2 years ago

It might be better just to remove warmup from the dcli or rename it to dcli get

whoizit commented 2 years ago

also dcli upgrade can be renamed to dcli self-upgrade

whoizit commented 2 years ago

I mean to avoid different names for equal subcommands in dcli and pub