search

onepub-dev / dcli

An extensive library and tooling for building console/cli applications and scripts using the Dart programming language.
245 stars 28 forks source link

Starting a command never releases it after finish #244

Closed jifferon closed 5 months ago

jifferon commented 5 months ago

Describe the bug When you run any command, e.g. using string syntax:

'mason make ...'.start(
   workingDirectory: componentFolderPath,
   terminal: true,
)

The command runs itself fine however nothing after that command is being executed and dcli script just hangs there, until you kill it with Control+C.

Same dcli script worked just fine on dcli: 3.4.0 and prior.

To Reproduce Use dcli: 4.0.1-beta.2

Expected behavior Excepting ''.start() to work normally and execute code further after command is finished.

bsutton commented 5 months ago

diego, thanks for the report. this was helpful. One of my own apps was exhibiting the same problem but I hadn't realised it was the terminal mode.

will investigate.

bsutton commented 5 months ago

so I think I have a fix for this, which I've pushed to master if you want to have a play.

I'm a little concerned that I've caused another issue as one of my other apps is now mis-behaving, will try and have a look tonight.

Brett

On Mon, Apr 8, 2024 at 10:50 PM jifferon @.***> wrote:

Describe the bug When you run any command, e.g. using string syntax:

'mason make ...'.start( workingDirectory: componentFolderPath, terminal: true, )

The command runs itself fine however nothing after that command is being executed and dcli script just hangs there, until you kill it with Control+C.

Same dcli script worked just fine on dcli: 3.4.0 and prior.

To Reproduce Use dcli: 4.0.1-beta.2

Expected behavior Excepting ''.start() to work normally and execute code further after command is finished.

— Reply to this email directly, view it on GitHub https://github.com/onepub-dev/dcli/issues/244, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG32ODGPZNL2BGGF4CQH6DY4KHC5AVCNFSM6AAAAABF4UWSTOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTCMJTG44TINA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

bsutton commented 5 months ago

I believe this is now fixed in beta.4

feel free to re-open if you are still having issues.

jifferon commented 5 months ago

Sorry for not answering to your previous message. Beta 4 actually did resolve that issue and whole flow now works flawlessly. Thank you very much 👍