Support non load/store components - Githubissues

onera / pml-analyzer

The PML analyzer is an open source API providing a simple DSL to build a description of the architecture of your chip based on the PHYLOG Modelling Language (PML).

https://w3.onera.fr/phylog/

GNU Lesser General Public License v2.1

5 stars 0 forks source link

Support non load/store components #16

Closed Gaudeval closed 7 months ago

Gaudeval commented 7 months ago

Description

Add a flag to support the creation of hardware components without the default Load and Store services.

Help would be appreciated for:

test case generation: the current tests use ad-hoc definitions instead of neat generators
code quality: a shorter flag name might be better, unclear on Scala naming conventions.

What type of pull request is this? (check all applicable)

[x] Feature
[ ] Bug Fix
[ ] Documentation Update
[ ] Style
[ ] Code Refactor
[ ] Performance Improvements
[x] Test
[x] Build
[ ] CI
[ ] Chore (Release)
[ ] Revert

Related Tickets & Documents

Closes #13

Added tests?

[x] yes
[ ] no, because they aren't needed
[ ] no, because I need help

Added to documentation?

[ ] README.md
[x] doc
[ ] no documentation needed

Do we need to update pml analyzer version?

[ ] no
[ ] the pull request is only a bug fix, need a bug fix version update
[x] the pull request add new features and ensures retro-compatibility, need a feature addition version update
[ ] the pull request is not ensuring retro-capatibility, need a major version update
[ ] not sure, I need help

Is this new version should be released as soon as possible?

[ ] yes
[x] no
[ ] not sure, I need help

Gaudeval commented 7 months ago

Thank you for the development. It is very nice, just a little thing, please add the explicit parameter naming "withDefaultServices=" in you last test. It improve a bit the readability :-)

You drove a hard bargain, but it is done. The hardware test will have to become more FlatSpec-friendly one day. One day...