search

onesine / react-tailwindcss-datepicker

Modern date range picker component for React using Tailwind 3 and dayjs. Alternative to Litepie Datepicker.
https://react-tailwindcss-datepicker.vercel.app/
MIT License
537 stars 159 forks source link

New option for setting the 'required' attribute on the date picker input element. #182

Closed scrappergus closed 1 month ago

scrappergus commented 1 year ago

I've added a simple boolean attribute to the Datepicker that allows you to set the input element's 'required' attribute.

In order to pass the pre-commit hooks, I had to disable the NextJS-related ESLint plugins when committing, and also change the line order in a couple files.

alphabetek commented 1 year ago

@onesine any chance to land this PR? Thank you in advance.

netgfx commented 10 months ago

Looking for this as well

idevstuffs commented 7 months ago

Great addition! I'm looking for this feature as well, please approve and merge!

onesine commented 1 month ago

Hello @scrappergus, @alphabetek, @idevstuffs 👋. Sorry for the late reply. Thanks for the contribution @scrappergus.

scrappergus commented 1 month ago

The commit was failing pre-commit hooks, so in order to create the pull-request, I had to.

On Aug 12, 2024, at 7:55 AM, Lewhe Onesine @.***> wrote:

@onesine commented on this pull request.

In .eslintrc.json https://github.com/onesine/react-tailwindcss-datepicker/pull/182#discussion_r1713822967:

@@ -10,8 +10,7 @@ "plugin:react/recommended", @.***/recommended", "plugin:prettier/recommended",

  • "plugin:react-hooks/recommended",
  • "next/core-web-vitals" Why remove this plugin

In .eslintrc.json https://github.com/onesine/react-tailwindcss-datepicker/pull/182#discussion_r1713823380:

@@ -27,7 +26,7 @@ "version": "detect" } },

  • "plugins": ["react", @.", "import", "prettier", @./eslint-plugin-next"], Why remove this plugin

— Reply to this email directly, view it on GitHub https://github.com/onesine/react-tailwindcss-datepicker/pull/182#pullrequestreview-2233103447, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN3OGLHS6JPXL32MQONNA3ZRC5F5AVCNFSM6AAAAAA3QGFMAGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZTGEYDGNBUG4. You are receiving this because you were mentioned.