onesine / react-tailwindcss-select

Tailwind Select Component for React.js
https://demo-react-tailwindcss-select.vercel.app/
MIT License
183 stars 38 forks source link

Update Options.tsx #17

Closed cha2hyun closed 1 year ago

cha2hyun commented 1 year ago

overflow-y-scroll' applies the same CSS properties as 'overflow-y-auto

onesine commented 1 year ago

Thanks @cha2hyun for this MR too. But if this applies the same CSS properties then why use it.

cha2hyun commented 1 year ago

Thanks @cha2hyun for this MR too. But if this applies the same CSS properties then why use it.

Hi there, The comment i wrote was a warning message from lint

image

Duplicate with the overflow-y option makes CssConflict

overflow-y-auto makes overflow-y: auto;

Use overflow-y-auto to allow vertical scrolling if needed.

overflow-y-scroll makes overflow-y: scroll;

Use overflow-y-scroll to allow vertical scrolling and always show scrollbars unless always-visible scrollbars are disabled by the operating system.

for my case overflow-y-auto works well 👍

onesine commented 1 year ago

Oh yes, it's a duplicate. I didn't realize that. I thought there was overflow-y-scroll and this PR just replaces it with overflow-y-auto.

Thanks for this PR