search

onesky / api-library-php5

PHP5 library for OneSky API
MIT License
19 stars 12 forks source link

Throw curl exception only if API called #11

Closed skolodyazhnyy closed 9 years ago

skolodyazhnyy commented 9 years ago

Hey,

It's much safer to throw Exception only if API is called. In current implementation, if you have autoloader load Client.php file, you will get an exception even if CURL is not needed (file included, but API is not used). It could be quite dangerous.

VLMH commented 9 years ago

Thanks! Will merge shortly.

BernardoSilva commented 9 years ago

Another PR solves this issue in a more elegant way, by specifying curl-extension as dependency for this library on composer .

This PR can be closed and merge only https://github.com/onesky/api-library-php5/pull/12