search

onesky / plugin-ios-ota

Over the air plugin
50 stars 8 forks source link

NSLocalizedStringFromTableInBundle support #24

Closed qclmnt closed 6 years ago

qclmnt commented 7 years ago

Hi do you guys planned to support NSLocalizedStringFromTableInBundle ?

bretdabaker commented 7 years ago

This method uses local NSBundle directly, by supporting NSLocalizedStringFromTableInBundle do you mean having the plugin fallbacks to specific bundle if the plugin fails to load translations from OneSky?

qclmnt commented 7 years ago

We need it to force a language translation sometimes :

Like this :

NSString *forcedBundleString = bundleString;
NSBundle *bundle = [NSBundle bundleWithPath:[[NSBundle mainBundle] pathForResource:forcedBundleString ofType:@"lproj"]];
return NSLocalizedStringFromTableInBundle(([NSString stringWithFormat:@"******.%@",language]), nil, bundle, nil);
siburb commented 7 years ago

@bretdabaker We could do with this too. We use NSLocalizedStringFromTableInBundle for accessing localized strings within our internal pods.

rubyluk commented 6 years ago

Fixed in https://github.com/onesky/plugin-ios-ota/releases/tag/0.10.1