search

onesky / plugin-ios-ota

Over the air plugin
50 stars 8 forks source link

iOS 9 bugs, possible solution #7

Closed Silkjaer closed 9 years ago

Silkjaer commented 9 years ago

We have people reporting errors after upgrading to iOS 9.

Localization abbreviation has changed, e.g. Danish was in iOS 8 and previous "da", but is in iOS 9 da-DK.

NSLocalizedString works as expected – it probably checks "da-DK" first and falls back to "da". Could this be implemented in OneSkyOTAPlugin.localizedStringForKey?

I imagine a fallback routine as follows:

  1. check for "da-DK"
  2. check for "da"
  3. check NSLocalizedString (for local strings)
  4. fallback to "en"

Now it seems it does as follows:

  1. check for "da-DK"
  2. fallback to "en"
bretdabaker commented 9 years ago

Thanks for reporting the bug, will look into it.

paolocolombo commented 9 years ago

hi, it's a avery annoying bug. Have you established a date for the resolution or shall we find a workaround?

bretdabaker commented 9 years ago

Will release a fix within 48 hours, right now you can duplicate the strings from dk to dk-DK on OneSky web admin so that it works on iOS 9.

paolocolombo commented 9 years ago

Hi bretdabaker, thanks for your precious feedback! Have a nice day.

bretdabaker commented 9 years ago

Fixed in 0.9.3