[CodeReview]-MVC-Controller - Githubissues

onesour / Net-Mvc-Workshop1

0 stars 0 forks source link

[CodeReview]-MVC-Controller #3

Open GSSBilly opened 5 years ago

GSSBilly commented 5 years ago

冗餘程式碼

請正確使用 DropDownList Helper 產生預設選項

https://github.com/hsuan51/Net-Mvc-Workshop1/blob/44836a994e9a1f6a3ee853ba09a21f6b97adf01c/Net-Mvc-Workshop1/Controllers/HomeController.cs#L22-L33

BOOK_ID 變數未重複使用，不須宣告 https://github.com/hsuan51/Net-Mvc-Workshop1/blob/44836a994e9a1f6a3ee853ba09a21f6b97adf01c/Net-Mvc-Workshop1/Controllers/HomeController.cs#L78-L79
可在查詢條件中利用 string.IsNullOrEmpty 判斷變數使用與否，不需要做轉換 https://github.com/hsuan51/Net-Mvc-Workshop1/blob/44836a994e9a1f6a3ee853ba09a21f6b97adf01c/Net-Mvc-Workshop1/Controllers/HomeController.cs#L104-L119

GSSBilly commented 5 years ago

缺乏後端驗證

https://github.com/hsuan51/Net-Mvc-Workshop1/blob/44836a994e9a1f6a3ee853ba09a21f6b97adf01c/Net-Mvc-Workshop1/Controllers/HomeController.cs#L46-L53

https://github.com/hsuan51/Net-Mvc-Workshop1/blob/44836a994e9a1f6a3ee853ba09a21f6b97adf01c/Net-Mvc-Workshop1/Controllers/HomeController.cs#L75-L97

GSSBilly commented 5 years ago

LINQ

資料篩選寫法請保持一致性，建議使用較精簡的 LINQ 語法 請善用 LINQ Where 只有名稱需要模糊查詢 https://github.com/hsuan51/Net-Mvc-Workshop1/blob/44836a994e9a1f6a3ee853ba09a21f6b97adf01c/Net-Mvc-Workshop1/Controllers/HomeController.cs#L102

https://github.com/hsuan51/Net-Mvc-Workshop1/blob/44836a994e9a1f6a3ee853ba09a21f6b97adf01c/Net-Mvc-Workshop1/Controllers/HomeController.cs#L120-L126