onespacemedia / cms

A collection of Django extensions that add content-management facilities to Django projects.
BSD 3-Clause "New" or "Revised" License
14 stars 7 forks source link

Fix ObjectDoesNotExist exception recovering pages with Reversion (reloaded) #195

Open lewiscollard opened 4 years ago

lewiscollard commented 4 years ago

This was previously done in #175. I prefer this implementation because:

  1. It fixes it in one place, not two
  2. It's addressing the problem, which is Watson throwing an exception on .content, in a narrower scope
  3. It doesn't quietly swallow ObjectDoesNotExist, which is something that we absolutely do want to be thrown if it happens.