search

onesteinbv / addons-container

1 stars 2 forks source link

previewer OCA only on account entries and not on formview #88

Closed ThijsvOers closed 11 months ago

ThijsvOers commented 11 months ago

We have implemented the OCA module account_move_line_attachment_preview, we only want to see the pdf preview on account movelines. At the moment this functionality is also visible on the formview of vendor bills/customer invoices. In the formview we want to see the standard odoo community solution.

astirpe commented 11 months ago

Temporary patch applied here: https://github.com/onesteinbv/addons-oca/commit/360ac3669eda58b5971e1ff225ff233b358a47ab The patch disables the OCA preview on the form only and leave it as standard Odoo preview. So it should be OK for the time being.

NOTE: Since the patch is made an OCA module, it should be modified to make it OCA proof and proposed to OCA. So my suggestion is: disabling the OCA preview on the form should be an optional feature, so that it can be configurable somehow.

I let you decide what to do with this issue: close it after tests or keep it open as a reminder for the future OCA implementation.

astirpe commented 11 months ago

See also comment https://github.com/OCA/knowledge/pull/434/files#r1403171727

astirpe commented 11 months ago

Temporary patch reverted for now, since issue https://github.com/OCA/web/issues/2682 prevents the Odoo PDF preview to be opened automatically.

ThijsvOers commented 11 months ago

@astirpe Antonio found the solution, he disabled the OCA preview module on vendor bills