onesteinbv / addons-onestein

Odoo modules developed by Onestein
https://www.onestein.nl/
GNU Affero General Public License v3.0
59 stars 102 forks source link

[10.0] Upgrade account_cost_spread (backport from V11) #65

Closed astirpe closed 6 years ago

CasVissers-360ERP commented 6 years ago

@astirpe Shouldn't we use date or invoice_date from account_invoice here? amount = current_currency.with_context(date=spread_date).compute(\ The spread amount should be the same as the booked amount by the invoice.

astirpe commented 6 years ago

@CasVissers is this what you mean?

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (10.0@11362d0). Click here to learn what that means. The diff coverage is 91.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             10.0      #65   +/-   ##
=======================================
  Coverage        ?   90.73%           
=======================================
  Files           ?       97           
  Lines           ?     2040           
  Branches        ?        0           
=======================================
  Hits            ?     1851           
  Misses          ?      189           
  Partials        ?        0
Impacted Files Coverage Δ
account_cost_spread/models/account_invoice.py 92.3% <ø> (ø)
...unt_cost_spread_all/models/account_invoice_line.py 62.5% <ø> (ø)
hr_absenteeism/models/hr_absenteeism_dates.py 100% <100%> (ø)
...absenteeism/models/hr_absenteeism_notifications.py 100% <100%> (ø)
hr_absenteeism/models/hr_holidays.py 100% <100%> (ø)
...rectory_file_download/models/ir_filesystem_file.py 86.11% <86.11%> (ø)
account_cost_spread/models/account_invoice_line.py 87.3% <87.01%> (ø)
...ry_file_download/models/ir_filesystem_directory.py 96.22% <96.22%> (ø)
..._cost_spread/models/account_invoice_spread_line.py 95.5% <97.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11362d0...992645f. Read the comment docs.

CasVissers-360ERP commented 6 years ago

@astirpe Thnx.