search

onestudio-co / flutter-bond

Your next Flutter project template!
173 stars 48 forks source link

Solving issue #78: now when you click on "change language" you get to choose which language do yo want. #127

Closed AbedrahmanYassen closed 11 months ago

AbedrahmanYassen commented 11 months ago

PART OF GTC OPEN SOURCE INTIATIVE

Pull Request Description

Now when the user clicks on the "Change language" button an alert will pop up to ask the user which language do want.

Related Issue: Issue #78

Proposed Changes

I have made an alert widget with a list of radio buttons inside to choose the language.

Screenshots (if applicable)

After: image

mohamedalwhaidi commented 11 months ago

Hello @AbedrahmanYassen ,

Thank you for your interest in our project and the effort you've put into this PR. We appreciate your initiative in addressing Issue #78.

However, I wanted to inform you that the issue in question has been reviewed and closed as it was part of the intended design given the current structure of the application. We concluded that the existing switch mechanism to toggle between languages is suitable for now, as we only support two languages.

That said, we have suggested a possible enhancement that involves creating a MorePage within the nav_bar. This enhancement would accommodate additional languages and features in the future, as well as enhance overall navigation within the app. We would be more than happy to review a PR regarding this improvement, should you wish to work on it.

Again, thank you for your time and dedication to our project. We hope to see more of your contributions in the future.

Best, Mohamed Alwhaidi

AbedrahmanYassen commented 11 months ago

Thank you for your email. I would love to help for sure. And I am trying my best to help in this project, but please list the issues you think would be a valuable addition to the project.

On Sat, 29 Jul 2023 at 17:08, Mohamed AlWhaidi @.***> wrote:

Closed #127 https://github.com/onestudio-co/flutter-bond/pull/127.

— Reply to this email directly, view it on GitHub https://github.com/onestudio-co/flutter-bond/pull/127#event-9954563751, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASWQNXUXLIRWHWO5UWTJ2ZTXSUKNJANCNFSM6AAAAAA24IX45E . You are receiving this because you were mentioned.Message ID: @.***>