search

onetrueawk / awk

One true awk
Other
1.98k stars 159 forks source link

Add GitHub CI #153

Closed jsoref closed 1 year ago

jsoref commented 2 years ago

https://github.com/onetrueawk/awk/blob/master/README.md#submitting-pull-requests suggests:

Please run the test suite and make sure that your changes pass before posting the pull request. To do so:

  1. Save the previous version of awk somewhere in your path. Call it nawk (for example).
  2. Run oldawk=nawk make check > check.out 2>&1.
  3. Search for BAD or error in the result. In general, look over it manually to make sure there are no errors.

It'd be nice if GitHub forks could automatically report failures in a way that drive-by contributors could do something with...

This is a draft of something that would almost do that.

Caveats:

  1. BAD appears to appear in the output naturally
  2. error does as well and I haven't seen it appear in a case when there's an error
  3. The test suite appears to fail on its own

I'm not really attached to diff -u, but there are a number of reasons to favor it:

  1. It's easier for someone looking at its output to figure out what changed
  2. Conveniently, it becomes much easier to identify failures and thus mark the CI as failed
plan9 commented 1 year ago

will be considered for a future release.