Closed jsoref closed 1 year ago
https://github.com/onetrueawk/awk/blob/master/README.md#submitting-pull-requests suggests:
Please run the test suite and make sure that your changes pass before posting the pull request. To do so: Save the previous version of awk somewhere in your path. Call it nawk (for example). Run oldawk=nawk make check > check.out 2>&1. Search for BAD or error in the result. In general, look over it manually to make sure there are no errors.
Please run the test suite and make sure that your changes pass before posting the pull request. To do so:
awk
nawk
oldawk=nawk make check > check.out 2>&1
BAD
error
It'd be nice if GitHub forks could automatically report failures in a way that drive-by contributors could do something with...
This is a draft of something that would almost do that.
Caveats:
I'm not really attached to diff -u, but there are a number of reasons to favor it:
diff -u
will be considered for a future release.
https://github.com/onetrueawk/awk/blob/master/README.md#submitting-pull-requests suggests:
It'd be nice if GitHub forks could automatically report failures in a way that drive-by contributors could do something with...
This is a draft of something that would almost do that.
Caveats:
BAD
appears to appear in the output naturallyerror
does as well and I haven't seen it appear in a case when there's an errorI'm not really attached to
diff -u
, but there are a number of reasons to favor it: