search

onetrueawk / awk

One true awk
Other
1.96k stars 156 forks source link

Fixed bison command in makefile #201

Closed absolutelynothinghere closed 8 months ago

absolutelynothinghere commented 9 months ago

The bison command was missing -b awkgram

arnoldrobbins commented 8 months ago

What is the point of this change? Does awk not build for you? If so, on what system? The current makefile works just fine on at least Linux and MacOS. Maybe you need a newer version of bison? Thanks.

absolutelynothinghere commented 8 months ago

yacc implementations other than bison need this change, see also https://github.com/onetrueawk/awk/issues/204

Is there harm in pushing this change? Does it stop awk from compiling on your machine?

plan9 commented 8 months ago

we already accommodated yaccs not named bison with the appropriate arguments for filename prefix.

absolutelynothinghere commented 8 months ago

Can you link to the aforementioned accommodations? I don't see any changes in the Makefile.