search

onetune / spotify-web-helper

🎛 Control Spotify from node.js
62 stars 11 forks source link

Fixed long loading time #35

Closed sekwah41 closed 6 years ago

sekwah41 commented 6 years ago

May need tidying up but did a quick fix to the massive waiting time while finding the correct port

JonnyBurger commented 6 years ago

Hi guys, just wanted to let you know while I don't have time to work on this, I will try to merge and publish the npm package as soon as you think it's good. Write me at jonathanburger11 at gmail.com in case I don't see it.

Thanks a lot for doing this!!

sekwah41 commented 6 years ago

@JonnyBurger no problem, I've got some coursework and a competition I need to work on atm but ill probably get some time this weekend to look over what @itotallyrock has said and neaten it up.

sekwah41 commented 6 years ago

@JonnyBurger the functionality has been updated to uses promises and has the same functionality as the current build when the connection cannot be found.

image

however this error is not due to the connecting code but rather if the connection cannot be found or Spotify is closed during use. An event for closing or on top of this a catch for the no port being found should be detected however for now I would say that should be a separate issue.

JonnyBurger commented 6 years ago

OK cool, should I publish this on npm?

eioo commented 6 years ago

Please do!

sekwah41 commented 6 years ago

@JonnyBurger im currently using it for some of my stuff and had no issues, I would say it is suitable for use. Ill take a look at the error that is happening when it doesnt set up right. I dont know if its because im not catching it usually or if its generally an issue. If its a general issue ill take a look and add an event that fires for spotify not being found.

itotallyrock commented 6 years ago

NPM package would help a lot with getting updates out to people, and this repo already seems to follow npm's guidelines, so it should be fine to publish it.

JonnyBurger commented 6 years ago

@sekwah41 @itotallyrock @Kallu609 You can now update via NPM!

Thank you everybody!