search

onetune / spotify-web-helper

🎛 Control Spotify from node.js
62 stars 11 forks source link

Adds a method to be able to get a fresh status if needed #36

Closed vincentaudebert closed 6 years ago

vincentaudebert commented 6 years ago

I needed to be able to "refresh" the status as I'm changing the track from another package too. This PR is adding getStatus to the object that way you can get a "fresh" status if needed.

Sorry for the prettifying in the git diff. You might want to add a eslint config so the code can be parsed automatically.

Useful line start here: https://github.com/onetune/spotify-web-helper/compare/master...vincentaudebert:feature/open-getstatus?expand=1#diff-168726dbe96b3ce427e7fedce31bb0bcR344

itotallyrock commented 6 years ago

The changes look good, didn't notice anything potentially problematic other than changes in formatting which shouldn't be an issue. Tests on my end worked, @JonnyBurger if you can't find any issues feel free to merge.

JonnyBurger commented 6 years ago

Thanks a lot! The only thing that I would wish is that the new method is documented in the README. Otherwise I will happily pull and update the package!

JonnyBurger commented 6 years ago

Added some documentation myself. Thank you for the PR!