onevcat / Kingfisher

A lightweight, pure-Swift library for downloading and caching images from the web.
MIT License
23.13k stars 2.64k forks source link

KingfisherManager.shared warning on Xcode 15.3 with Strict Concurrency Checking set to complete #2229

Closed diogot closed 5 months ago

diogot commented 5 months ago

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

Issue Description

Xcode 15.3 add extra Swift 6 warnings when Strict Concurrency Checking is set to complete, one of those is on KingfisherManager.shared.

What

Screenshot 2024-04-08 at 08 45 49

Reproduce

onevcat commented 5 months ago

We have some progress on fully supporting of concurrency in the upcoming major release, which is now on the v8 branch. However, the fully Strict Concurrency compatible is still a long-term target for now. There are some key features lacked in the current Swift concurrency model (for example, the isolated deinit).

diogot commented 5 months ago

Looking forward to it, thanks!

onevcat commented 5 months ago

Full strict concurrency checking has been implemented, and a pull request has been submitted as #2241. With further refinement, we should be able to release a beta version of the new major update for Kingfisher.

Please allow me to close this issue for now.

diogot commented 5 months ago

Thanks!