search

oney / react-native-gcm-android

GCM for React Native Android
MIT License
172 stars 76 forks source link

Fixes 'google-services.json is missing' error #18

Closed lukefanning closed 8 years ago

lukefanning commented 8 years ago

Resolves #3

oney commented 8 years ago

Thanks! I can't reproduce the issue, but the app still works after removing apply plugin: 'com.google.gms.google-services' from android/build.gradle. So, I think removing it will help some people prevent facing this issue.

I don't want to remove react-native-system-notification dependency from this module, because I plan to use this module to create notifications. It more focuses on creating notification, and react-native-gcm-android focuses on GCM. Although it has some issue so I don't use it, let it stay here now.

Can you add a commit not to remove react-native-system-notification in this PR? And I will merge it.

lukefanning commented 8 years ago

Yeah I was thinking about how our app would generate notifications while its not running and doing it via the background service in your module would be great :). Restored the dependency.

oney commented 8 years ago

Currently this module support to create notification when the app is not running(closed). See this When the app is closed and receive GCM notification, it will create BackgroundService to launch a React Native instance to handle notification. After finishing, BackgroundService will be destroyed.

fender commented 8 years ago

@oney Can you create a new release for NPM after the commit 8 days ago? ^

oney commented 8 years ago

@fender No problem. Done in 0.1.6