oney / react-native-gcm-android

GCM for React Native Android
MIT License
172 stars 76 forks source link

Notifications belong in individual module build.gradle files #46

Open pickhardt opened 8 years ago

pickhardt commented 8 years ago

I am installing this right now, and when I go to add the classpath to the build.gradle dependencies, there's a comment already that says:

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files

I think I shouldn't be adding this library's dependency to this file. I'll continuing doing it for now, but it seems like it is not supposed to be done, according to the comment.

pergunt commented 6 years ago

Same problem. I need to generate APK from react native but the contents of the file are different from the instructions in the documentation. I dont see keys 'android ', android ' etc like showed on the docs