search

oney / react-native-gcm-android

GCM for React Native Android
MIT License
172 stars 76 forks source link

Use global `Map` #6

Closed ghost closed 8 years ago

ghost commented 8 years ago

Do not require it from internal structure of react-native, as explained in facebook/react-native#4396.

ghost commented 8 years ago

This should help to solve #4 in a correct way, making it work with npm3 as well.

oney commented 8 years ago

Thanks. So modify codes below?

var Map = require('Map');
ghost commented 8 years ago

Howard Yang wrote:

Thanks. So modify codes below?

var Map = require('Map');

just remove it. Map is global and you can just use it.

— Reply to this email directly or view it on GitHub https://github.com/oney/react-native-gcm-android/issues/6#issuecomment-160330325.

oney commented 8 years ago

OK. I see.

oney commented 8 years ago

We can get it on version 0.0.6 with npm now. Thanks for searching solution!

ghost commented 8 years ago

It helps me as well ;-)

Howard Yang wrote:

We can get it on version 0.0.6 with npm now. Thanks for searching solution!

— Reply to this email directly or view it on GitHub https://github.com/oney/react-native-gcm-android/issues/6#issuecomment-160330753.

ghost commented 8 years ago

Fixed by b3c773b1c4ac99301872079ec26622461baeafe0