search

oney / react-native-gcm-android

GCM for React Native Android
MIT License
172 stars 76 forks source link

Do not use `invariant` at all #7

Closed ghost closed 8 years ago

ghost commented 8 years ago

It is purely internal to react-native and should not be used by outside code, as explained in facebook/react-native#4397.

ghost commented 8 years ago

This should help to solve #4 in a correct way, making it work with npm3 as well.

oney commented 8 years ago

I will remove invariant

ghost commented 8 years ago

If you want to enforce it somehow, you can still if (...check wrong condition...) throw new Error("Invariant not true."); or something...

Howard Yang wrote:

I will remove |invariant|

— Reply to this email directly or view it on GitHub https://github.com/oney/react-native-gcm-android/issues/7#issuecomment-160330354.

oney commented 8 years ago

Will verify arguments in the future.

ghost commented 8 years ago

Removed in b3c773b1c4ac99301872079ec26622461baeafe0, may be closed, maybe?

oney commented 8 years ago

@herby It should be closed!

oney commented 8 years ago

By the way, we have invariant package in npm now.