onflapp / gs-desktop

GNUstep Desktop
https://onflapp.github.io/gs-desktop/index.html
MIT License
101 stars 6 forks source link

Applications/Network needs -lutil #21

Closed mclarenlabs closed 10 months ago

mclarenlabs commented 10 months ago

Performed ./clean_world.sh, ./build_world.sh and building of Applications/Network failed on Debian. (See below) Suggest adding

    ADDITIONAL_LDFLAGS = -lutil

to Network/GNUmakefile to pick up forkpty.

Making all for app Network...
 Creating Network.app/....
 Compiling file AppController.m ...
 Compiling file MiniView.m ...
AppController.m:323:30: warning: incompatible pointer types initializing 'DKPort<NMAccessPoint> *' with an expression of type 'DKProxy *' [-Wincompatible-pointer-types]
      DKPort<NMAccessPoint> *ap = device.ActiveAccessPoint;
                             ^    ~~~~~~~~~~~~~~~~~~~~~~~~
AppController.m:383:10: warning: unused variable 'viewFrame' [-Wunused-variable]
  NSRect viewFrame;
         ^
AppController.m:430:29: warning: incompatible pointer types sending 'DKProxy<NMActiveConnection> *' to parameter of type 'DKProxy<NMConnectionSettings> *' [-Wincompatible-pointer-types]
        updateForConnection:device.ActiveConnection];
                            ^~~~~~~~~~~~~~~~~~~~~~~
./EthernetController.h:21:62: note: passing argument to parameter 'conn' here
- (void)updateForConnection:(DKProxy<NMConnectionSettings> *)conn;
                                                             ^
AppController.m:448:29: warning: incompatible pointer types sending 'DKProxy<NMActiveConnection> *' to parameter of type 'DKProxy<NMConnectionSettings> *' [-Wincompatible-pointer-types]
        updateForConnection:device.ActiveConnection];
                            ^~~~~~~~~~~~~~~~~~~~~~~
./EthernetController.h:21:62: note: passing argument to parameter 'conn' here
- (void)updateForConnection:(DKProxy<NMConnectionSettings> *)conn;
                                                             ^
AppController.m:581:30: warning: incompatible pointer types initializing 'DKPort<NMAccessPoint> *' with an expression of type 'DKProxy *' [-Wincompatible-pointer-types]
      DKPort<NMAccessPoint> *ap = dev.ActiveAccessPoint;`<
                             ^    ~~~~~~~~~~~~~~~~~~~~~
5 warnings generated.
 Compiling file ConnectionManager.m ...
 Compiling file NMSetup.m ...
 Compiling file WifiController.m ...
NMSetup.m:29:9: warning: instance method '-clearBuffer:' not found (return type defaults to 'id') [-Wobjc-method-access]
  [self clearBuffer:self];
        ^~~~~~~~~~~
./NMSetup.h:10:12: note: receiver is instance of class declared here
@interface NMTerminalView : TerminalView
           ^
1 warning generated.
 Compiling file EthernetController.m ...
 Compiling file Network_main.m ...
 Linking app Network ...
/Library/Libraries/libTerminalKit.so: error: undefined reference to 'forkpty'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[3]: *** [/Developer/Makefiles/Instance/application.make:131: Network.app/./Network] Error 1
gmake[2]: *** [/Developer/Makefiles/Instance/application.make:145: internal-app-run-compile-submake] Error 2
gmake[1]: *** [/Developer/Makefiles/Master/rules.make:297: Network.all.app.variables] Error 2
make: *** [/Developer/Makefiles/Master/application.make:38: internal-all] Error 2
onflapp commented 10 months ago

Should be OK now. Thanks!